Codecov Report

Attention: Patch coverage is 78.77814% with 198 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

Giving an update here.

1. We need a way of organizing the traversal to identify expression-blocks to wrap. Currently, you could attempt to check line lengths and wrap conditionally as you go (tried this), but it won't work easily if you need multiple wraps per block. My thought is we need a Wrap type that's just used while traversing the PSEs and checks the span column length and start_line diff to turn wrapping on or off.

2. We need to figure out ignored_expr for skipping formatting if specified. The function that exists is basically a stub but it should be possible to reconstruct the source from the PSE spans..

3. There's a fair amount of nested indentation that fails within golden tests (the unit tests don't test this much). I would guess that a better way of handling indentation wrapping would ease this (rather than the current attempt of passing in previous_indentation and constructing the string from that.. Very error prone.

4. This is more of a refactor, but basically we're doing way too much arg passing. There's a branch (experiment-with-accumulator) which i attempted to use an Accumulator struct to pass around the relevant info for constructing the result but it got a bit hairy with dereferencing and ultimately stack overflowed when I got it compiling. It's probably worth looking into because it would help fix 3 implicitly with the indent dedent and newline methods on Accumulator